[llvm] [FuncSpec] Query SCCPSolver in more places (PR #114964)

[Alexandros Lamprineas via llvm-commits]

================
@@ -312,10 +317,10 @@ bool InstCostVisitor::discoverTransitivelyIncomingValues(
 
       // Disregard self-references and dead incoming values.
       if (auto *Inst = dyn_cast<Instruction>(V))
-        if (Inst == PN || DeadBlocks.contains(PN->getIncomingBlock(I)))
----------------
labrinea wrote:

That doesn't seem right. The InstCostVisitor may have found a basic block dead even if the solver thinks it is executable.

https://github.com/llvm/llvm-project/pull/114964