[llvm] [FuncSpec] Query SCCPSolver in more places (PR #114964)

[Alexandros Lamprineas via llvm-commits]

================
@@ -135,15 +137,18 @@ Cost InstCostVisitor::estimateBasicBlocks(
     // executable and only reachable from dead blocks.
     for (BasicBlock *SuccBB : successors(BB))
       if (isBlockExecutable(SuccBB) &&
-          canEliminateSuccessor(BB, SuccBB, DeadBlocks))
+          canEliminateSuccessor(BB, SuccBB, DeadBlocks, Solver))
         WorkList.push_back(SuccBB);
   }
   return CodeSize;
 }
 
-static Constant *findConstantFor(Value *V, ConstMap &KnownConstants) {
+static Constant *findConstantFor(Value *V, ConstMap &KnownConstants,
----------------
labrinea wrote:

It may be worth it to turn this into a const member function if the callsites allow it. This way we don't have to pass KnownConstants or the Solver.

https://github.com/llvm/llvm-project/pull/114964