[llvm] [TableGen] Migrate Option Emitters to const RecordKeeper (PR #107696)

Rahul Joshi via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 07:06:11 PDT 2024


jurahul wrote:

I don’t think as there are no true duplicates here (i.e, 2 different
objects with the same value). It seems std::sort is calling its comparator
using the same Record pointer as A and B on some MacOS versions. If two
different records lead to same option, then that’s an error the code
intends to flag.

On Wed, Sep 11, 2024 at 7:01 AM Matt Arsenault ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
>
> Should these be using stable_sort
>
>> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/107696#pullrequestreview-2297187392>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB4M77NVDYRYE4ODYYLZWBEKRAVCNFSM6AAAAABNZ7SX32VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJXGE4DOMZZGI>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>


https://github.com/llvm/llvm-project/pull/107696


More information about the llvm-commits mailing list