[llvm] LV: fix style after cursory reading (NFC) (PR #105830)

Ramkumar Ramachandra via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 6 08:09:24 PDT 2024


artagnon wrote:

> I'll say here that I don't appreciate this kind of PR. Yes, this brings the code more in line with the letter of the coding standard, but I don't think that the code has become any easier to read after this PR. This just takes up reviewer time, makes git blame less useful, and invites bikeshedding (for example, whether you should omit braces on ifs with a comment inside or not is not universally agreed on).

Thanks for letting me know. I won't put up such PRs in the future. The yellow squigglies in VSCode have been irritating me for a long time now (due to clang-tidy), and I thought I should finally fix it in a couple of minutes. However, I realize that it has unnecessarily taken up reviewer time, and I apologize for this.

https://github.com/llvm/llvm-project/pull/105830


More information about the llvm-commits mailing list