[llvm] LV: fix style after cursory reading (NFC) (PR #105830)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 6 07:29:47 PDT 2024
https://github.com/nikic approved this pull request.
This looks fine to me, but I'll say here that I don't appreciate this kind of PR. Yes, this brings the code more in line with the letter of the coding standard, but I don't think that the code has become any easier to read after this PR. This just takes up reviewer time, makes git blame less useful, and invites bikeshedding (for example, whether you should omit braces on ifs with a comment inside or not is not universally agreed on).
https://github.com/llvm/llvm-project/pull/105830
More information about the llvm-commits
mailing list