[llvm] [AArch64]Fix invalid use of ld1/st1 in stack alloc (PR #105518)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 4 06:10:48 PDT 2024
================
@@ -3355,8 +3360,8 @@ bool AArch64FrameLowering::spillCalleeSavedRegisters(
MachineMemOperand::MOStore, Size, Alignment));
MIB.addReg(PnReg);
MIB.addReg(AArch64::SP)
- .addImm(RPI.Offset) // [sp, #offset*scale],
- // where factor*scale is implicit
+ .addImm(RPI.Offset / 2) // [sp, #offset*2*scale],
+ // where scale is implicit
----------------
Lukacma wrote:
Yeah I was debating this comment. It depends what does the "offset" part in the comment mean. If it refers to RPI.Offset, then current comment is accurate, if it refers to RPI.Offset/2 then this change is correct. I thought that because RPI.Offset has "offset" in the name, I would make "offset" in the comment refer to it.
https://github.com/llvm/llvm-project/pull/105518
More information about the llvm-commits
mailing list