[llvm] [llvm-objcopy][ELF] Disable huge section offset (PR #97036)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 23:32:17 PDT 2024


MaskRay wrote:

> @MaskRay, what do you think about this patch? I've not really got a good understanding of binary output, so can't be 100% confident about any reviewing I do.

Frankly, I hope that we leave llvm-objcopy unchanged for #88878.
Users can request object files with sections exceeding 0x80000000, and llvm-objcopy should handle those requests as intended.
Overly defensive measures often create more problems than they solve. If someone adds a new writer, do we port this output size limiting code to that?
An optional flag for this behavior seems unlikely to be used.

Note: we did introduce a default size limit for yaml2obj (10MiB) https://reviews.llvm.org/D81258 .
The primary reason is that yaml2obj is an internal testing tool, instead of a user-facing one.


https://github.com/llvm/llvm-project/pull/97036


More information about the llvm-commits mailing list