[llvm] AMDGPU: Start fixing inconsistencies in usage of SubtargetPredicate (PR #96337)

[Matt Arsenault via llvm-commits]

arsenm wrote:

> I think it is too useful for encapsulation and deduplication to apply different predicates on the members of a multiclass to forbid this, even though it is impossible to tell if that has been done when inheriting from the class except by inspecting the code.

This would be helped by a consistent convention at least. using SubtargetPredicate and OtherPredicates as the top level let is currently mixed.



https://github.com/llvm/llvm-project/pull/96337