[llvm] AMDGPU: Start fixing inconsistencies in usage of SubtargetPredicate (PR #96337)

[Joe Nash via llvm-commits]

https://github.com/Sisyph commented:

I am agnostic on the code changes themselves.

To understand the behavior it is necessary to consider the union of all Predicates, whether they are SubtargetPredicate, OtherPredicate, or True16Predicate. I would not care if we renamed them to Predicate0, Predicate1, Predicate2.

I think it is too useful for encapsulation and deduplication to apply different predicates on the members of a multiclass to forbid this, even though it is impossible to tell if that has been done when inheriting from the class except by inspecting the code.


https://github.com/llvm/llvm-project/pull/96337