[llvm] [NFC][AMDGPU] Do not flush after printing every instruction (PR #95237)

Pierre van Houtryve via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 20 06:13:13 PDT 2024


Pierre-vh wrote:

> > > Easy, but probably not ideal from performance and disk wearing perspectives.
> > 
> > 
> > Flushing too often - just because some tests aren't updated - is very likely way worse for performance (and your disk's lifespan).
> 
> Agree, we still should not flush on every instruction. It's just that there are probably better ways than writing to a file.

If the test is small and you really don't want to create a file (I don't understand why though), you could just run it twice, and one captures errors while the other captures stdout.

> I've always hated having the error and non error tests mixed. It would be way easier to understand split tests

It'd be nice to have a way to have separate check lines for stderr and stdout without an intermediate file


https://github.com/llvm/llvm-project/pull/95237


More information about the llvm-commits mailing list