[llvm] [GOFF] Refactor writing GOFF records (PR #93855)

[James Henderson via llvm-commits]

================
@@ -0,0 +1,7 @@
+# RUN: not yaml2obj %s 2>&1 | FileCheck %s
+
+# CHECK: yaml2obj: error: conversion to EBCDIC 1047 failed on 'Euro symbol €'
+
+--- !GOFF
+- End:
+    EntryName: "Euro symbol €"
----------------
jh7370 wrote:

I'm sure it's fine, but non-ascii characters in input files make me nervous because of issues with different default encodings with different programs. If I were to open this file in e.g. notepad on Windows, I'd expect the € character to not be interpreted correctly.

That being said, since the pre-merge check passes, this is probably fine for now (we can tackle any issues in the future).

https://github.com/llvm/llvm-project/pull/93855