[llvm] [GOFF] Refactor writing GOFF records (PR #93855)

[James Henderson via llvm-commits]

================
@@ -181,11 +184,13 @@ void GOFFState::writeHeader(GOFFYAML::ModuleHeader &ModHdr) {
     LR << *ModHdr.Properties; // Module properties.
 }
 
-void GOFFState::writeEnd(GOFFYAML::EndOfModule &EndMod) {
+void GOFFState::writeEnd(const GOFFYAML::EndOfModule &EndMod) {
+  // See https://www.ibm.com/docs/en/zos/3.1.0?topic=formats-end-module-record.
   SmallString<16> EntryName;
   if (std::error_code EC =
           ConverterEBCDIC::convertToEBCDIC(EndMod.EntryName, EntryName))
-    reportError("Conversion error on " + EndMod.EntryName);
+    reportError("conversion to EBCDIC 1047 failed on '" + EndMod.EntryName +
+                "'");
----------------
jh7370 wrote:

How about "failed to convert \<EndMod.EntryName\> to EBCDIC 1047"? (replacing the bit in \<\> with the appropriate C++ of course)

https://github.com/llvm/llvm-project/pull/93855