[llvm] llvm-rc: add support for MENU in DIALOG(EX) (PR #89409)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 27 02:03:27 PDT 2024


================
@@ -419,18 +419,18 @@ RCParser::parseSingleOptionalStatement(OptStmtType StmtsType) {
   if (TypeToken->equals_insensitive("VERSION"))
     return parseVersionStmt();
 
-  if (StmtsType != OptStmtType::BasicStmt) {
----------------
mstorsjo wrote:

Ok, I see - that sounds reasonable. So, were these only supported in `DIALOGEX` before, now they’re supported in both?

It would be good to clarify this in the commit message (PR description), that we’re making the other existing statements available in the other form, too.

Depending on which form was supported before and what gets supported here now, it might be good to add a test to cover that too. But if all the existing statements only were supported in `DIALOGEX` and the new test covers `DIALOG`, that’s probably good enough test coverage.

https://github.com/llvm/llvm-project/pull/89409


More information about the llvm-commits mailing list