[llvm] llvm-rc: add support for MENU in DIALOG(EX) (PR #89409)

via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 27 01:42:44 PDT 2024


================
@@ -419,18 +419,18 @@ RCParser::parseSingleOptionalStatement(OptStmtType StmtsType) {
   if (TypeToken->equals_insensitive("VERSION"))
     return parseVersionStmt();
 
-  if (StmtsType != OptStmtType::BasicStmt) {
----------------
oltolm wrote:

I looked at the documentation for [`DIALOG`](https://learn.microsoft.com/en-us/windows/win32/menurc/dialog-resource) and [`DIALOGEX`](https://learn.microsoft.com/en-us/windows/win32/menurc/dialogex-resource) and they support the same "optional statements". I don't know why llvm-rc distinguished between `DIALOG` and `DAILOGEX` here.

I also checked [Resource Hacker](https://angusj.com/resourcehacker/) and it also supports the same "optional statements" for both.

https://github.com/llvm/llvm-project/pull/89409


More information about the llvm-commits mailing list