[llvm] [SampleProfileLoader] Fix integer overflow in generateMDProfMetadata (PR #90217)
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 26 10:37:50 PDT 2024
================
@@ -1713,13 +1713,16 @@ void SampleProfileLoader::generateMDProfMetadata(Function &F) {
// if needed. Sample counts in profiles are 64-bit unsigned values,
// but internally branch weights are expressed as 32-bit values.
if (Weight > std::numeric_limits<uint32_t>::max()) {
- LLVM_DEBUG(dbgs() << " (saturated due to uint32_t overflow)");
+ LLVM_DEBUG(dbgs() << " (saturated due to uint32_t overflow)\n");
Weight = std::numeric_limits<uint32_t>::max();
}
if (!SampleProfileUseProfi) {
// Weight is added by one to avoid propagation errors introduced by
// 0 weights.
- Weights.push_back(static_cast<uint32_t>(Weight + 1));
+ if (Weight != std::numeric_limits<uint32_t>::max())
+ Weight += 1;
----------------
MatzeB wrote:
This will change the value of `Weight` below in line 1735 (or 1732 before). Probably should assign to some temporary variable.
https://github.com/llvm/llvm-project/pull/90217
More information about the llvm-commits
mailing list