[llvm] [coro][pgo] Remove redundant coroutine test files (PR #89620)

via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 06:48:02 PDT 2024


zmodem wrote:

> How about removing the PGO RUN: from the coro side and leaving these on the PGO side handle that?

I think that would be a step in the wrong direction. It would still be a copy-paste of the test code, which is a definite code smell.

The current setup (on the coro side) with multiple run-lines for running each test in different configs is the way to go.

> One reason I could think of, to keep the PGO side, is for code review auto-notification (i.e. because the pgo pr "team" is auto-added)

It sounds like auto notifications is the main motivation here? In that case, I think the pgo team should subscribe to the coro dir.

> Are there any lit tricks to make it read from the equivalent tests under Transforms/Coroutines directory instead of %s? So that we only have one copy of the test body, but still give you notifications for PGO team.

Just subscribing to the coro test dir seems easier.

https://github.com/llvm/llvm-project/pull/89620


More information about the llvm-commits mailing list