[llvm] [DAGCombiner] Fix miscompile bug in combineShiftOfShiftedLogic (PR #89616)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 01:36:34 PDT 2024


================
@@ -788,61 +788,31 @@ define <4 x i32> @or_tree_with_mismatching_shifts_vec_i32(<4 x i32> %a, <4 x i32
   ret <4 x i32> %r
 }
 
-; FIXME: Reproducer for a DAGCombiner::combineShiftOfShiftedLogic
-; bug. DAGCombiner need to check that the sum of the shift amounts fits in i8,
-; which is the legal type used to described X86 shift amounts. Verify that we
-; do not try to create a shift with 140+120 as shift amount, and verify that
----------------
jayfoad wrote:

Should be 130+160?

https://github.com/llvm/llvm-project/pull/89616


More information about the llvm-commits mailing list