[llvm] [UTC] Don't leave dangling CHECK-SAME when removing CHECK lines (PR #82569)
Alexander Richardson via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 22 15:13:22 PST 2024
================
@@ -388,7 +388,11 @@ def itertests(
def should_add_line_to_output(
- input_line, prefix_set, skip_global_checks=False, comment_marker=";"
+ input_line,
+ prefix_set,
+ skip_global_checks=False,
+ skip_same_checks=False,
+ comment_marker=";",
----------------
arichardson wrote:
```suggestion
input_line,
prefix_set,
*,
skip_global_checks=False,
skip_same_checks=False,
comment_marker=";",
```
Since you added a new parameter it seems like no callers actually pass `comment_marker` here?
I find function calls with various boolean flags quite hard to parse, maybe make these parameters named arguments?
https://github.com/llvm/llvm-project/pull/82569
More information about the llvm-commits
mailing list