[llvm] Extend GCC workaround to GCC < 8.4 for llvm::iterator_range ctor (PR #82643)
Thomas Preud'homme via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 22 08:02:43 PST 2024
https://github.com/RoboTux created https://github.com/llvm/llvm-project/pull/82643
GCC SFINAE error with decltype was fixed in commit
ac5e28911abdfb8d9bf6bea980223e199bbcf28d which made it into GCC 8.4.
Therefore adjust GCC version test accordingly.
>From 9d4c0cdb76c8e079ac33e6636a94baed3ba1097b Mon Sep 17 00:00:00 2001
From: Balazs Benics <benicsbalazs at gmail.com>
Date: Tue, 18 Jul 2023 09:15:11 +0200
Subject: [PATCH] Extend GCC workaround to GCC < 8.4 for llvm::iterator_range
ctor
GCC SFINAE error with decltype was fixed in commit
ac5e28911abdfb8d9bf6bea980223e199bbcf28d which made it into GCC 8.4.
Therefore adjust GCC version test accordingly.
---
llvm/include/llvm/ADT/iterator_range.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/llvm/include/llvm/ADT/iterator_range.h b/llvm/include/llvm/ADT/iterator_range.h
index 2dc227935984b1..7d288ea4506ba5 100644
--- a/llvm/include/llvm/ADT/iterator_range.h
+++ b/llvm/include/llvm/ADT/iterator_range.h
@@ -43,8 +43,8 @@ class iterator_range {
IteratorT begin_iterator, end_iterator;
public:
-#if __GNUC__ == 7
- // Be careful no to break gcc-7 on the mlir target.
+#if __GNUC__ == 7 || (__GNUC__ == 8 && __GNUC_MINOR__ < 4)
+ // Be careful no to break gcc-7 and gcc-8 < 8.4 on the mlir target.
// See https://github.com/llvm/llvm-project/issues/63843
template <typename Container>
#else
More information about the llvm-commits
mailing list