[llvm] a0b3dba - [InstCombine] Regenerate some fcmp tests to use the update_test_checks.py script

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 02:50:27 PST 2024


Author: Simon Pilgrim
Date: 2024-02-21T10:46:12Z
New Revision: a0b3dbaf4b3c01dc7f0a83fce059a26360b58eb2

URL: https://github.com/llvm/llvm-project/commit/a0b3dbaf4b3c01dc7f0a83fce059a26360b58eb2
DIFF: https://github.com/llvm/llvm-project/commit/a0b3dbaf4b3c01dc7f0a83fce059a26360b58eb2.diff

LOG: [InstCombine] Regenerate some fcmp tests to use the update_test_checks.py script

Added: 
    

Modified: 
    llvm/test/Transforms/InstCombine/2008-05-23-CompareFold.ll
    llvm/test/Transforms/InstCombine/2008-11-08-FCmp.ll
    llvm/test/Transforms/InstCombine/2009-05-23-FCmpToICmp.ll
    llvm/test/Transforms/InstCombine/2012-02-13-FCmp.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/2008-05-23-CompareFold.ll b/llvm/test/Transforms/InstCombine/2008-05-23-CompareFold.ll
index 66751eb704548a..76b443bc22a73b 100644
--- a/llvm/test/Transforms/InstCombine/2008-05-23-CompareFold.ll
+++ b/llvm/test/Transforms/InstCombine/2008-05-23-CompareFold.ll
@@ -1,14 +1,17 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt -passes=instcombine -S < %s | FileCheck %s
 ; PR2359
 
-; CHECK-LABEL: @f(
-; CHECK: ret i1 false
 define i1 @f(ptr %x) {
+; CHECK-LABEL: @f(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    ret i1 false
+;
 entry:
-       %tmp462 = load i8, ptr %x, align 1          ; <i8> [#uses=1]
-       %tmp462463 = sitofp i8 %tmp462 to float         ; <float> [#uses=1]
-       %tmp464 = fcmp ugt float %tmp462463, 0x47EFFFFFE0000000         ; <i1>
-       ret i1 %tmp464
+  %tmp462 = load i8, ptr %x, align 1          ; <i8> [#uses=1]
+  %tmp462463 = sitofp i8 %tmp462 to float         ; <float> [#uses=1]
+  %tmp464 = fcmp ugt float %tmp462463, 0x47EFFFFFE0000000         ; <i1>
+  ret i1 %tmp464
 }
 
 

diff  --git a/llvm/test/Transforms/InstCombine/2008-11-08-FCmp.ll b/llvm/test/Transforms/InstCombine/2008-11-08-FCmp.ll
index fe3071bf0c01aa..6df5ac40ca7c39 100644
--- a/llvm/test/Transforms/InstCombine/2008-11-08-FCmp.ll
+++ b/llvm/test/Transforms/InstCombine/2008-11-08-FCmp.ll
@@ -1,63 +1,74 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -passes=instcombine -S | FileCheck %s
 ; PR3021
 
 ; When inst combining an FCMP with the LHS coming from a uitofp instruction, we
 ; can't lower it to signed ICMP instructions.
 
-; CHECK-LABEL: @test1(
 define i1 @test1(i32 %val) {
+; CHECK-LABEL: @test1(
+; CHECK-NEXT:    [[TMP1:%.*]] = icmp eq i32 [[VAL:%.*]], 0
+; CHECK-NEXT:    ret i1 [[TMP1]]
+;
   %1 = uitofp i32 %val to double
   %2 = fcmp ole double %1, 0.000000e+00
-; CHECK: icmp eq i32 %val, 0
   ret i1 %2
 }
 
-; CHECK-LABEL: @test2(
 define i1 @test2(i32 %val) {
+; CHECK-LABEL: @test2(
+; CHECK-NEXT:    ret i1 false
+;
   %1 = uitofp i32 %val to double
   %2 = fcmp olt double %1, 0.000000e+00
   ret i1 %2
-; CHECK: ret i1 false
 }
 
-; CHECK-LABEL: @test3(
 define i1 @test3(i32 %val) {
+; CHECK-LABEL: @test3(
+; CHECK-NEXT:    ret i1 true
+;
   %1 = uitofp i32 %val to double
   %2 = fcmp oge double %1, 0.000000e+00
   ret i1 %2
-; CHECK: ret i1 true
 }
 
-; CHECK-LABEL: @test4(
 define i1 @test4(i32 %val) {
+; CHECK-LABEL: @test4(
+; CHECK-NEXT:    [[TMP1:%.*]] = icmp ne i32 [[VAL:%.*]], 0
+; CHECK-NEXT:    ret i1 [[TMP1]]
+;
   %1 = uitofp i32 %val to double
   %2 = fcmp ogt double %1, 0.000000e+00
-; CHECK: icmp ne i32 %val, 0
   ret i1 %2
 }
 
-; CHECK-LABEL: @test5(
 define i1 @test5(i32 %val) {
+; CHECK-LABEL: @test5(
+; CHECK-NEXT:    ret i1 true
+;
   %1 = uitofp i32 %val to double
   %2 = fcmp ogt double %1, -4.400000e+00
   ret i1 %2
-; CHECK: ret i1 true
 }
 
-; CHECK-LABEL: @test6(
 define i1 @test6(i32 %val) {
+; CHECK-LABEL: @test6(
+; CHECK-NEXT:    ret i1 false
+;
   %1 = uitofp i32 %val to double
   %2 = fcmp olt double %1, -4.400000e+00
   ret i1 %2
-; CHECK: ret i1 false
 }
 
 ; Check that optimizing unsigned >= comparisons correctly distinguishes
 ; positive and negative constants.  <rdar://problem/12029145>
-; CHECK-LABEL: @test7(
 define i1 @test7(i32 %val) {
+; CHECK-LABEL: @test7(
+; CHECK-NEXT:    [[TMP1:%.*]] = icmp ugt i32 [[VAL:%.*]], 3
+; CHECK-NEXT:    ret i1 [[TMP1]]
+;
   %1 = uitofp i32 %val to double
   %2 = fcmp oge double %1, 3.200000e+00
   ret i1 %2
-; CHECK: icmp ugt i32 %val, 3
 }

diff  --git a/llvm/test/Transforms/InstCombine/2009-05-23-FCmpToICmp.ll b/llvm/test/Transforms/InstCombine/2009-05-23-FCmpToICmp.ll
index 7f32f947aa2164..0ceaf5a61361ea 100644
--- a/llvm/test/Transforms/InstCombine/2009-05-23-FCmpToICmp.ll
+++ b/llvm/test/Transforms/InstCombine/2009-05-23-FCmpToICmp.ll
@@ -1,9 +1,13 @@
-; RUN: opt < %s -passes=instcombine -S | not grep cmp
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
 ; rdar://6903175
 
 define i1 @f0(ptr %a) nounwind {
-       %b = load i32, ptr %a, align 4
-       %c = uitofp i32 %b to double
-       %d = fcmp ogt double %c, 0x41EFFFFFFFE00000
-       ret i1 %d
+; CHECK-LABEL: @f0(
+; CHECK-NEXT:    ret i1 false
+;
+  %b = load i32, ptr %a, align 4
+  %c = uitofp i32 %b to double
+  %d = fcmp ogt double %c, 0x41EFFFFFFFE00000
+  ret i1 %d
 }

diff  --git a/llvm/test/Transforms/InstCombine/2012-02-13-FCmp.ll b/llvm/test/Transforms/InstCombine/2012-02-13-FCmp.ll
index 7366b50ed4b51f..82c5817f06e2b4 100644
--- a/llvm/test/Transforms/InstCombine/2012-02-13-FCmp.ll
+++ b/llvm/test/Transforms/InstCombine/2012-02-13-FCmp.ll
@@ -1,3 +1,4 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt -passes=instcombine -S < %s | FileCheck %s
 ; Radar 10803727
 @.str = private unnamed_addr constant [35 x i8] c"\0Ain_range input (should be 0): %f\0A\00", align 1
@@ -5,13 +6,33 @@
 
 declare i32 @printf(ptr, ...)
 define i64 @_Z8tempCastj(i32 %val) uwtable ssp {
+; CHECK-LABEL: @_Z8tempCastj(
+; CHECK-NEXT:  entry:
+; CHECK-NEXT:    [[CALL:%.*]] = call i32 (ptr, ...) @printf(ptr noundef nonnull dereferenceable(1) @.str1, i32 [[VAL:%.*]])
+; CHECK-NEXT:    [[CONV:%.*]] = uitofp i32 [[VAL]] to double
+; CHECK-NEXT:    [[CALL_I:%.*]] = call i32 (ptr, ...) @printf(ptr noundef nonnull dereferenceable(1) @.str, double [[CONV]])
+; CHECK-NEXT:    br i1 true, label [[LAND_RHS_I:%.*]], label [[IF_END_CRITEDGE:%.*]]
+; CHECK:       land.rhs.i:
+; CHECK-NEXT:    [[CMP1_I:%.*]] = icmp eq i32 [[VAL]], 0
+; CHECK-NEXT:    br i1 [[CMP1_I]], label [[IF_THEN:%.*]], label [[IF_END:%.*]]
+; CHECK:       if.then:
+; CHECK-NEXT:    [[ADD:%.*]] = fadd double [[CONV]], 5.000000e-01
+; CHECK-NEXT:    [[CONV3:%.*]] = fptosi double [[ADD]] to i64
+; CHECK-NEXT:    br label [[RETURN:%.*]]
+; CHECK:       if.end.critedge:
+; CHECK-NEXT:    br label [[IF_END]]
+; CHECK:       if.end:
+; CHECK-NEXT:    br label [[RETURN]]
+; CHECK:       return:
+; CHECK-NEXT:    [[RETVAL_0:%.*]] = phi i64 [ [[CONV3]], [[IF_THEN]] ], [ -1, [[IF_END]] ]
+; CHECK-NEXT:    ret i64 [[RETVAL_0]]
+;
 entry:
   %call = call i32 (ptr, ...) @printf(ptr @.str1, i32 %val)
   %conv = uitofp i32 %val to double
   %call.i = call i32 (ptr, ...) @printf(ptr @.str, double %conv)
   %cmp.i = fcmp oge double %conv, -1.000000e+00
   br i1 %cmp.i, label %land.rhs.i, label %if.end.critedge
-; CHECK:  br i1 true, label %land.rhs.i, label %if.end.critedge
 
 land.rhs.i:                                       ; preds = %entry
   %cmp1.i = fcmp olt double %conv, 1.000000e+00


        


More information about the llvm-commits mailing list