[llvm] [SHT_LLVM_BB_ADDR_MAP] Adds pretty printing of BFI and BPI for PGO Analysis Map in tools. (PR #82292)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 00:16:57 PST 2024


================
@@ -5031,7 +5031,7 @@ template <class ELFT> void GNUELFDumper<ELFT>::printCGProfile() {
   OS << "GNUStyle::printCGProfile not implemented\n";
 }
 
-template <class ELFT> void GNUELFDumper<ELFT>::printBBAddrMaps() {
+template <class ELFT> void GNUELFDumper<ELFT>::printBBAddrMaps(bool) {
----------------
jh7370 wrote:

I feel like it's more common practice to comment out unused parameter names, rather than omit them entirely. Especially here, it means that if GNUStyle is ever implemented, it's clear what the option means without having to look it up.

https://github.com/llvm/llvm-project/pull/82292


More information about the llvm-commits mailing list