[llvm] [BOLT][DWARF] Add support for .debug_names (PR #81062)

Amir Ayupov via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 13:11:30 PST 2024


================
@@ -378,11 +377,13 @@ getUnitForOffset(DIEBuilder &Builder, DWARFContext &DWCtx,
   return nullptr;
 }
 
-uint32_t DIEBuilder::computeDIEOffset(const DWARFUnit &CU, DIE &Die,
+uint32_t DIEBuilder::computeDIEOffset(DWARFUnit &CU, DIE &Die,
----------------
aaupov wrote:

I'm strongly in favor of keeping CU a const ref since semantically `computeDIEOffset` should not change the input CU (or DIE). Please make modifications to the CU outside of this method.

https://github.com/llvm/llvm-project/pull/81062


More information about the llvm-commits mailing list