[llvm] repair and re-enable Windows buildkite presubmit (PR #82393)

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 12:05:39 PST 2024


================
@@ -49,7 +49,10 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
       -D COMPILER_RT_BUILD_ORC=OFF \
       -D CMAKE_C_COMPILER_LAUNCHER=sccache \
       -D CMAKE_CXX_COMPILER_LAUNCHER=sccache \
-      -D MLIR_ENABLE_BINDINGS_PYTHON=ON
+      -D MLIR_ENABLE_BINDINGS_PYTHON=ON \
+      -D CMAKE_EXE_LINKER_FLAGS="/MANIFEST:NO" \
+      -D CMAKE_MODULE_LINKER_FLAGS="/MANIFEST:NO" \
+      -D CMAKE_SHARED_LINKER_FLAGS="/MANIFEST:NO"
----------------
AaronBallman wrote:

I think it might make sense to add comments around here explaining why we're doing this; otherwise it'll be a head-scratcher a few months from now.

https://github.com/llvm/llvm-project/pull/82393


More information about the llvm-commits mailing list