[llvm] [llvm][unittests] add NDEBUG for some unittests (PR #80821)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 09:07:33 PST 2024


aeubanks wrote:

> For example, in a few cases, I would like to use the checks that report errors with errs(), rather than using assert(). 

I don't understand this sentence, can you clarify?

> And also, when the user enables EXPENSIVE_CHECKS and NDEBUG, there is no prompt that such settings are wrong, but these two unit tests will fail. I think this is an issue.

That's fair, it would be good to have a check for this either in CMake or in some header. I would prefer this option.

https://github.com/llvm/llvm-project/pull/80821


More information about the llvm-commits mailing list