[llvm] [AMDGPU][NFC] Extend PredicateControl to support True16 predicates. (PR #82245)

Changpeng Fang via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 10:49:25 PST 2024


================
@@ -1484,8 +1484,8 @@ multiclass VOP3_Real_dpp8_with_name<GFXGen Gen, bits<10> op, string opName,
   let AsmString = asmName # ps.Pfl.AsmVOP3DPP8,
       DecoderNamespace = "DPP8"#Gen.DecoderNamespace#
                          !if(ps.Pfl.IsRealTrue16, "", "_FAKE16"),
-      OtherPredicates = !if(ps.Pfl.IsRealTrue16, [UseRealTrue16Insts],
----------------
changpeng wrote:

There are other places in the same file that also need to be taken care of:
VOP3_DPP16_Gen, VOP3_Real_Gen for example.
Do we actually have to introduce True16Predicate? 
I think we have already used listconcat to add a new predicate into OtherPredicates list. 


https://github.com/llvm/llvm-project/pull/82245


More information about the llvm-commits mailing list