[llvm] [RemoveDIs] Print non-intrinsic debug info in textual IR output (PR #79281)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 09:05:17 PST 2024


https://github.com/jmorse commented:

This LGTM in principle with a few nits and some test questions. It looks like it'll only be possible to get this format out of `opt` and other tools that print through the pass-manager, so things like `llvm-dis` won't immediately be able to print this format. IMO this is fine as we're looking to incrementally expand what parts of LLVM support this format.

On the topic of the format, I think the one area where we're limiting ourselves a little is if we add or remove operands to "records" (ex-intrinsics) in the future. Previously with the intrinsics being variadic, it's been trivial to mess with them, which won't be true going forwards. However IMO some future parsing complexity is a perfectly good price to pay for having non-intrinsic debug-info.

The new format seems fine to me -- after all it's the same data, we're just explicitly making it "not-an-instruction". (We should probably find some syntax highlighters and update them)

https://github.com/llvm/llvm-project/pull/79281


More information about the llvm-commits mailing list