[llvm] [XCOFF] make related SD symbols as isFunction (PR #69553)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 01:00:39 PDT 2023


================
@@ -83,8 +83,30 @@ class SymbolizableObjectFile : public SymbolizableModule {
     // getNameFromSymbolTable.
     uint32_t ELFLocalSymIdx;
 
+    // Both are false if this is not a XCOFF local symbol.
+    bool IsXCOFFSDSymbol;
+    bool IsXCOFFLDSymbol;
----------------
jh7370 wrote:

Is it possible for these to both be true? If not, perhaps an enum, something like `XCOFFSymbolClass`, would be more appropriate? In fact, an enum might be better in general, to avoid having to keep track of multiple different fields.

https://github.com/llvm/llvm-project/pull/69553


More information about the llvm-commits mailing list