[llvm] [XCOFF] make related SD symbols as isFunction (PR #69553)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 26 01:00:38 PDT 2023


================
@@ -83,8 +83,30 @@ class SymbolizableObjectFile : public SymbolizableModule {
     // getNameFromSymbolTable.
     uint32_t ELFLocalSymIdx;
 
+    // Both are false if this is not a XCOFF local symbol.
+    bool IsXCOFFSDSymbol;
+    bool IsXCOFFLDSymbol;
+
     bool operator<(const SymbolDesc &RHS) const {
-      return Addr != RHS.Addr ? Addr < RHS.Addr : Size < RHS.Size;
+      if (Addr != RHS.Addr)
+        return Addr < RHS.Addr;
+
+      // This is a XCOFF symbol.
----------------
jh7370 wrote:

I think this comment is incorrect: the symbol might not be an XCOFF symbol at all, right?

https://github.com/llvm/llvm-project/pull/69553


More information about the llvm-commits mailing list