[llvm] [BOLT] Support instrumentation hook via DT_FINI_ARRAY (PR #67348)

Vladislav Khmelevsky via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 02:34:53 PDT 2023


yota9 wrote:

> As far as I understand, the problem is not writing the test but actually running it since we currently need an AArch64 host for that. And if we have an AArch64 host, we might as well just execute the instrumented binary for testing purposes. Or am I missing something?

No, you're right about it :)

> Just to understand things better: why is this a problem?

I think you might misunderstood me. It is not a problem to have this runtime test, I only say that we prefer the non runtime tests in BOLT. We still can have this one, it is fine, but ideally since it is easy to arrange I would suggest to add non runtime test too.


https://github.com/llvm/llvm-project/pull/67348


More information about the llvm-commits mailing list