[llvm] [BOLT] Support instrumentation hook via DT_FINI_ARRAY (PR #67348)

Job Noorman via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 6 00:26:20 PDT 2023


mtvec wrote:

> We can keep the current test I guess, but it would be better to add non-runtime.. Since currently it relies on the binary successfully exit

Just to understand things better: why is this a problem?

> The non-runtime test should be easy to do, but it is just monotonic job, although the filecheck prefixes would be repeated across the multiple tests, so I guess it won't be too hard to find the needed symbol and check relocation(s) against it..

As far as I understand, the problem is not writing the test but actually running it since we currently need an AArch64 host for that. And if we have an AArch64 host, we might as well just execute the instrumented binary for testing purposes. Or am I missing something?

https://github.com/llvm/llvm-project/pull/67348


More information about the llvm-commits mailing list