[PATCH] D152205: [Aarch64][SVE]SVE2] Enable tbl, tbl2 for shuffle lowering for fixed vector types.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-vector-shuffle-tbl.ll:118
+
+define <8 x i8> @shuffle_index_poison_value(ptr %a, ptr %b) {
+; SVE2_128-LABEL: shuffle_index_poison_value:
----------------
This test is missing check lines for the shuffle mask, could you please add it?


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-vector-shuffle-tbl.ll:177
+
+define <8 x i8> @shuffle_op2_poison(ptr %a, ptr %b) {
+; CHECK-LABEL: shuffle_op2_poison:
----------------
I'm a bit puzzled, why did you add this test?


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-vector-shuffle-tbl.ll:201
+; because for i8 type, the maximum constant in the mask is 256.
+define <8 x i8> @shuffle_index_size_negative_op_both_maxhw(ptr %a, ptr %b) "target-features"="+sve2" vscale_range(16,16) {
+; CHECK-LABEL: shuffle_index_size_negative_op_both_maxhw:
----------------
nit: I meant prepend do the start of the name, e.g. `@negative_test_shuffle_index_size_op_both_maxhw`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152205/new/

https://reviews.llvm.org/D152205