[PATCH] D138847: MC/DC in LLVM Source-Based Code Coverage: llvm-cov visualization

Wed Sep 20 14:51:32 PDT 2023

alanphipps added a comment.

In D138847#4649079 <https://reviews.llvm.org/D138847#4649079>, @MaskRay wrote:

> Please, when landing a large patch, check whether clang can build the project. The original commit caused -Wswitch failure which I fixed in ca22d6e40508f6d24a9352835bda9c152e3eee1b <https://reviews.llvm.org/rGca22d6e40508f6d24a9352835bda9c152e3eee1b>.
>
> When reverting a patch, run the test as well. `ninja clang` did not build due to ca22d6e40508f6d24a9352835bda9c152e3eee1b <https://reviews.llvm.org/rGca22d6e40508f6d24a9352835bda9c152e3eee1b> not being part of the revert.

Yes, thanks -- I did build my changes prior to landing them, but I did not see the -Wswitch failure until it landed, not sure why.  These changes are actually addressed in the successive commit, which I will now apply here.  I reverted due to test failures on windows and did not see your commit to address the -Wswitch failure.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138847/new/

https://reviews.llvm.org/D138847