[llvm] aa71680 - [lit] Fix a test fail under windows

Joel E. Denny via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 15:06:08 PDT 2023


Author: Joel E. Denny
Date: 2023-09-19T18:05:13-04:00
New Revision: aa71680f2948ac177144e1089c58d55b9ac0cef2

URL: https://github.com/llvm/llvm-project/commit/aa71680f2948ac177144e1089c58d55b9ac0cef2
DIFF: https://github.com/llvm/llvm-project/commit/aa71680f2948ac177144e1089c58d55b9ac0cef2.diff

LOG: [lit] Fix a test fail under windows

Seen at
<https://lab.llvm.org/buildbot/#/builders/216/builds/27531/steps/7/logs/FAIL__lit___shtest-run-at-line_py>.

Discussed starting at
<https://github.com/llvm/llvm-project/pull/66408#issuecomment-1726448368>.

Added: 
    

Modified: 
    llvm/utils/lit/tests/shtest-run-at-line.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/tests/shtest-run-at-line.py b/llvm/utils/lit/tests/shtest-run-at-line.py
index b92aee97628b25d..a1bdb039805ad4f 100644
--- a/llvm/utils/lit/tests/shtest-run-at-line.py
+++ b/llvm/utils/lit/tests/shtest-run-at-line.py
@@ -1,8 +1,15 @@
 # Check that -a/-v/-vv makes the line number of the failing RUN command clear.
 
-# RUN: not %{lit} -a %{inputs}/shtest-run-at-line | FileCheck %s
-# RUN: not %{lit} -v %{inputs}/shtest-run-at-line | FileCheck %s
-# RUN: not %{lit} -vv %{inputs}/shtest-run-at-line | FileCheck %s
+
+# This diagnostic sometimes appears in windows when using bash as an external
+# shell.  Ignore it so we can strictly check the relevant output.
+#
+# DEFINE: %{filter} = \
+# DEFINE:   grep -v 'bash.exe: warning: could not find /tmp, please create!'
+
+# RUN: not %{lit} -a %{inputs}/shtest-run-at-line | %{filter} | FileCheck %s
+# RUN: not %{lit} -v %{inputs}/shtest-run-at-line | %{filter} | FileCheck %s
+# RUN: not %{lit} -vv %{inputs}/shtest-run-at-line | %{filter} | FileCheck %s
 # END.
 
 


        


More information about the llvm-commits mailing list