[llvm] [InstrRef][NFC] Improve diagram illustrating locations (PR #66944)

via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 12:14:26 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-debuginfo

<details>
<summary>Changes</summary>

The "register number" arrow should point to `LocationID`, not `LocIdx`.

---
Full diff: https://github.com/llvm/llvm-project/pull/66944.diff


1 Files Affected:

- (modified) llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h (+2-2) 


``````````diff
diff --git a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
index 30de18e53c4fb43..5e94962f9d7e648 100644
--- a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
+++ b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
@@ -602,8 +602,8 @@ class LocIdxToIndexFunctor {
 /// Slot Num (%stack.0)   /
 /// FrameIdx => SpillNum /
 ///              \      /
-///           SpillID (int)              Register number (int)
-///                      \                  /
+///           SpillID (int)   Register number (int)
+///                      \       /
 ///                      LocationID => LocIdx
 ///                                |
 ///                       LocIdx => ValueIDNum

``````````

</details>


https://github.com/llvm/llvm-project/pull/66944


More information about the llvm-commits mailing list