[llvm] [InstrRef][NFC] Improve diagram illustrating locations (PR #66944)

Felipe de Azevedo Piovezan via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 12:13:16 PDT 2023


https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/66944

The "register number" arrow should point to `LocationID`, not `LocIdx`.

>From f2eb403768fc7d2a50e7df06e5b7f5b8d2b636e9 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
Date: Wed, 20 Sep 2023 15:09:38 -0400
Subject: [PATCH] [InstrRef][NFC] Improve diagram illustrating locations

The "register number" arrow should point to `LocationID`, not `LocIdx`.
---
 llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
index 30de18e53c4fb43..5e94962f9d7e648 100644
--- a/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
+++ b/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
@@ -602,8 +602,8 @@ class LocIdxToIndexFunctor {
 /// Slot Num (%stack.0)   /
 /// FrameIdx => SpillNum /
 ///              \      /
-///           SpillID (int)              Register number (int)
-///                      \                  /
+///           SpillID (int)   Register number (int)
+///                      \       /
 ///                      LocationID => LocIdx
 ///                                |
 ///                       LocIdx => ValueIDNum



More information about the llvm-commits mailing list