[compiler-rt] [sanitizer_symbolizer] Symbolizer Markup for linux. (PR #65543)

Florian Mayer via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 7 11:28:29 PDT 2023


================
@@ -26,10 +28,10 @@ class StackTraceTextPrinter {
                         InternalScopedString *output,
                         InternalScopedString *dedup_token)
       : stack_trace_fmt_(stack_trace_fmt),
-        frame_delimiter_(frame_delimiter),
-        output_(output),
         dedup_token_(dedup_token),
-        symbolize_(RenderNeedsSymbolization(stack_trace_fmt)) {}
+        symbolize_(RenderNeedsSymbolization(stack_trace_fmt, false)),
----------------
fmayer wrote:

This doesn't seem right, this seems like a hardcoded false

```
bool RenderNeedsSymbolization(const char *format, bool symbolizer_markup) {
  if (symbolizer_markup) {
    // Online symbolization is never needed for symbolizer markup.
    return false;
  }
```

https://github.com/llvm/llvm-project/pull/65543


More information about the llvm-commits mailing list