[compiler-rt] [sanitizer_symbolizer] Symbolizer Markup for linux. (PR #65543)
Florian Mayer via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 7 11:28:29 PDT 2023
================
@@ -103,12 +103,22 @@ void PrintStack(const ReportStack *ent) {
Printf(" [failed to restore the stack]\n\n");
return;
}
+
+ if (const ListOfModules *modules =
+ Symbolizer::GetOrInit()->GetRefreshedListOfModules()) {
+ InternalScopedString modules_res;
+ RenderModules(&modules_res, modules,
----------------
fmayer wrote:
I would prefer if this and the other caller looked like
```
if (common_flags()->enable_symbolizer_markup)
RenderModulesMarkup(...);
```
The indirection doesn't add much and only obscures what is happening.
https://github.com/llvm/llvm-project/pull/65543
More information about the llvm-commits
mailing list