[llvm] [llvm] Adopt WithMarkup in the MIPS backend (PR #65384)

Jonas Devlieghere via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 5 11:26:42 PDT 2023


================
@@ -213,12 +213,11 @@ void MipsInstPrinter::printMemOperand(const MCInst *MI, int opNum,
     break;
   }
 
-  O << markup("<mem:");
+  WithMarkup M = markup(O, Markup::Memory);
----------------
JDevlieghere wrote:

LLDB uses the ANSI escape characters for coloring, not the markup annotations so for LLDB this becomes a NOOP as you pointed out. I don't know who relies on the markup annotations but it's probably best to keep the existing behavior to avoid breaking any tools that might be relying on it.  

https://github.com/llvm/llvm-project/pull/65384


More information about the llvm-commits mailing list