[llvm] [llvm] Adopt WithMarkup in the MIPS backend (PR #65384)
Sergei Barannikov via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 5 11:03:40 PDT 2023
================
@@ -213,12 +213,11 @@ void MipsInstPrinter::printMemOperand(const MCInst *MI, int opNum,
break;
}
- O << markup("<mem:");
+ WithMarkup M = markup(O, Markup::Memory);
----------------
s-barannikov wrote:
Ah, I was thinking about colors and forgot about the "<mem:" part.
I don't know what the markup has beed used for and whether nested tags are allowed. I was trying to say that the memory operand will not have Memory style. Instead, it will be displayed as Immediate + Register or Register + Register (and default-style parentheses). If that's OK from lldb's point of view, I don't see other issues.
https://github.com/llvm/llvm-project/pull/65384
More information about the llvm-commits
mailing list