[PATCH] D158623: [RISCV] Reorder the stack frame objects.

[Wang Pengcheng via Phabricator via llvm-commits]

wangpc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:555
+  const unsigned Opcode = MI.getOpcode();
+  return isCompressibleLwOrSw(STI, Opcode) ||
+         isCompressibleLdOrSd(STI, Opcode) ||
----------------
Do we really need these small inline functions? What about making them branches (manually inlining)?


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:583
+  for (auto &Obj : ObjectsToAllocate) {
+    SortingObjects[Obj].IsValid = true;
+    SortingObjects[Obj].ObjectIndex = Obj;
----------------
Do we really need `IsValid`? It's always true I think (same for X86).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158623/new/

https://reviews.llvm.org/D158623