[PATCH] D158623: [RISCV] Reorder the stack frame objects.

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 00:03:50 PDT 2023


wangpc added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:583
+  for (auto &Obj : ObjectsToAllocate) {
+    SortingObjects[Obj].IsValid = true;
+    SortingObjects[Obj].ObjectIndex = Obj;
----------------
wangpc wrote:
> Do we really need `IsValid`? It's always true I think (same for X86).
OK, ignore it. `SortingObjects` is with bigger size than `ObjectsToAllocate`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158623/new/

https://reviews.llvm.org/D158623



More information about the llvm-commits mailing list