[PATCH] D158623: [RISCV] Reorder the stack frame objects.

lcvon via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 07:45:39 PDT 2023


lcvon007 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:528
+         Opcode == RISCV::LD || Opcode == RISCV::FLD || Opcode == RISCV::SW ||
+         (!STI.is64Bit() && Opcode == RISCV::FSW) || Opcode == RISCV::SD ||
+         Opcode == RISCV::FSD;
----------------
craig.topper wrote:
> Don't we need to check C or Zcf/Zcd for compressing FP loads and stores? They aren't compressible with just Zca.
I have added function to check whether lw/ld/flw/fld/sw/sd/fsw/fsd is compressible. thanks very much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158623/new/

https://reviews.llvm.org/D158623



More information about the llvm-commits mailing list