[PATCH] D158489: [X86][GlobalISel] Move GlobalISel source files to a dedicated subdir

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 10:55:30 PDT 2023


RKSimon added a comment.

In D158489#4607468 <https://reviews.llvm.org/D158489#4607468>, @MaskRay wrote:

> In D158489#4605997 <https://reviews.llvm.org/D158489#4605997>, @RKSimon wrote:
>
>> Since only AArch64 + RiscV currently use a subdir - why not just move them up instead?
>
> I am confused. `{AArch64,M68k,PowerPC,RISCV}/GISel` are present. This patch creates `X86/GISel/`. What do you suggest?

I'm confused too :) If the plan is to eventually just have GISel why have them in a subdir?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158489/new/

https://reviews.llvm.org/D158489



More information about the llvm-commits mailing list