[PATCH] D158489: [X86][GlobalISel] Move GlobalISel source files to a dedicated subdir

Tue Aug 22 10:59:23 PDT 2023

MaskRay added a comment.

In D158489#4607498 <https://reviews.llvm.org/D158489#4607498>, @RKSimon wrote:

> In D158489#4607468 <https://reviews.llvm.org/D158489#4607468>, @MaskRay wrote:
>
>> In D158489#4605997 <https://reviews.llvm.org/D158489#4605997>, @RKSimon wrote:
>>
>>> Since only AArch64 + RiscV currently use a subdir - why not just move them up instead?
>>
>> I am confused. `{AArch64,M68k,PowerPC,RISCV}/GISel` are present. This patch creates `X86/GISel/`. What do you suggest?
>
> I'm confused too :) If the plan is to eventually just have GISel why have them in a subdir?

This `X86/GISel` directory makes it clear what files are GlobalISel related. `X86/` contains other files (Subtarget,TargetMachine,X86-specific codegen optimizations,etc) and some SelectionDAG related files.
If eventually we can get rid of SelectionDAG (not sure how feasible it is, but looks like a project of 10+ years), we would still have some `X86/` files.
This `X86/GISel` directory would still be useful to separate GlobalISel related files.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158489/new/

https://reviews.llvm.org/D158489