[PATCH] D158489: [X86][GlobalISel] Move GlobalISel source files to a dedicated subdir

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D158489#4605997 <https://reviews.llvm.org/D158489#4605997>, @RKSimon wrote:

> Since only AArch64 + RiscV currently use a subdir - why not just move them up instead?

I am confused. `{AArch64,M68k,PowerPC,RISCV}/GISel` are present. This patch creates `X86/GISel/`. What do you suggest?



================
Comment at: llvm/lib/Target/X86/CMakeLists.txt:87-90
+  GISel/X86CallLowering.cpp
+  GISel/X86InstructionSelector.cpp
+  GISel/X86LegalizerInfo.cpp
+  GISel/X86RegisterBankInfo.cpp
----------------
pengfei wrote:
> Move them to the top to keep alphabetical order.
My reasoning is that placing files before directories is also an order, but I can move GISel if you are strong about it...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158489/new/

https://reviews.llvm.org/D158489