[PATCH] D158062: [RISCV] Teach RISCVMergeBaseOffset to handle inline asm

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVMergeBaseOffset.cpp:462
+        }
+        NewMI->addOperand(UseMI.getOperand(I));
+        NewMI->addOperand(ImmOp);
----------------
craig.topper wrote:
> Can we use MachineOperand::ChangeToGA and MachineOperand::ChangeToMCSymbol to avoid building a new instruction?
Though I guess we would also need ChangeToCPI for constant pool?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158062/new/

https://reviews.llvm.org/D158062