[PATCH] D156569: [InstrProf] Encode linkage names in IRPGO counter names

[Ellis Hoag via Phabricator via llvm-commits]

ellis added inline comments.


================
Comment at: llvm/lib/ProfileData/InstrProf.cpp:313
+// See getPGOFuncName()
+std::string getIRPGOFuncName(const Function &F, bool InLTO) {
+  if (!InLTO) {
----------------
MaskRay wrote:
> https://llvm.org/docs/CodingStandards.html#use-namespace-qualifiers-to-implement-previously-declared-functions
Unfortunately most of this file is wrapped in `namespace llvm {}` so this gives a warning
```
warning: extra qualification on member 'getIRPGOFuncName' [-Wextra-qualification]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156569/new/

https://reviews.llvm.org/D156569