[PATCH] D156720: AMDGPU: Try to use private version of sincos if available
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 31 10:26:26 PDT 2023
arsenm created this revision.
arsenm added reviewers: AMDGPU, rampitec, jmmartinez, Pierre-vh, yaxunl, vpykhtin, dfukalov.
Herald added subscribers: foad, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.
The comment was out of date, the device libs build does provide all
the pointer overloads. An extremely pedantic interpretation of the
spec would suggest only the flat version exists, but the overloads do
exist in the implementation.
https://reviews.llvm.org/D156720
Files:
llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.defined.ll
llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.ll
llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.nobuiltins.ll
llvm/test/CodeGen/AMDGPU/simplify-libcalls.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D156720.545732.patch
Type: text/x-patch
Size: 60600 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230731/9cf62ab2/attachment-0001.bin>
More information about the llvm-commits
mailing list