[PATCH] D157091: AMDGPU/Uniformity/GlobalISel: G_AMDGPU atomics are always divergent

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 07:35:29 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:8647
 
   if (SIInstrInfo::isGenericAtomicRMWOpcode(opcode) ||
       opcode == AMDGPU::G_ATOMIC_CMPXCHG ||
----------------
Petar.Avramovic wrote:
> arsenm wrote:
> > Isn't this covered by this already?
> This is for G_ATOMIC... (generic rmw atomics), we need to handle G_AMDGPU_ .. ATOMIC ..
This should come down here with the others then 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157091/new/

https://reviews.llvm.org/D157091



More information about the llvm-commits mailing list