[PATCH] D152366: [LoopVectorize] Allow inner loop runtime checks to be hoisted above an outer loop

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1774
+    if (A.StrideToCheck) {
+      Value *IsPositiveStride = ChkBuilder.CreateICmpSLT(
+          A.StrideToCheck, ConstantInt::get(A.StrideToCheck->getType(), 0));
----------------
Should this be `IsNegativeStride` given you're planting `A.StrideToCheck < 0`?

Perhaps it's worth giving the node a name like "stride.check"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152366/new/

https://reviews.llvm.org/D152366